Skip to content

fix CI attestation integration tests after rename#13536

Merged
BagToad merged 1 commit into
trunkfrom
bagtoad/kw-fix-attestation-integration-tests
May 27, 2026
Merged

fix CI attestation integration tests after rename#13536
BagToad merged 1 commit into
trunkfrom
bagtoad/kw-fix-attestation-integration-tests

Conversation

@BagToad
Copy link
Copy Markdown
Member

@BagToad BagToad commented May 27, 2026

fix CI attestation integration tests after rename

Commit e6dfcd3 ("fix: use separate http client for non-github hosts")
renamed verification.SigstoreConfig.HttpClient to ExternalHttpClient,
added an external *http.Client argument to api.NewLiveClient, and added
the corresponding Factory.ExternalHttpClient field. It updated the
non-tagged unit tests but missed every //go:build integration file in
pkg/cmd/attestation/..., which broke trunk CI (build (ubuntu-latest)
and build (macos-latest) in the Unit and Integration Tests workflow):

- pkg/cmd/attestation/verification and pkg/cmd/attestation/verify
  failed to build (unknown field HttpClient; not enough arguments in
  call to api.NewLiveClient).
- TestNewInspectCmd_PrintOutputJSONFormat panicked because the
  cmdutil.Factory literal it builds did not set ExternalHttpClient,
  so the new f.ExternalHttpClient() call in inspect.go dereferenced
  a nil func value.

Rename the field at the integration-test call sites, pass
http.DefaultClient as the new external client to api.NewLiveClient,
and populate ExternalHttpClient on the inspect test factory. No
production code changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BagToad BagToad requested review from a team as code owners May 27, 2026 17:28
@BagToad BagToad requested a review from babakks May 27, 2026 17:28
@BagToad BagToad merged commit f96972c into trunk May 27, 2026
18 checks passed
@BagToad BagToad deleted the bagtoad/kw-fix-attestation-integration-tests branch May 27, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants